feat: Add paths getter, toString, and toDot to PathTrie for debugging #320
Merged
nielsenko merged 1 commit intoserverpod:mainfrom Jan 27, 2026
Merged
feat: Add paths getter, toString, and toDot to PathTrie for debugging #320nielsenko merged 1 commit intoserverpod:mainfrom
nielsenko merged 1 commit intoserverpod:mainfrom
Conversation
Contributor
📝 WalkthroughWalkthroughAdds debugging support to PathTrie by introducing a public API to enumerate all registered path patterns via a Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nielsenko
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 91.18% 91.31% +0.12%
==========================================
Files 97 97
Lines 3723 3777 +54
Branches 1905 1929 +24
==========================================
+ Hits 3395 3449 +54
Misses 328 328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds the ability to enumerate and visualize all registered paths in a PathTrie for debugging routing issues. - Add `paths` getter that returns an Iterable<String> of all registered paths - Add `toString()` override for quick debugging output - Add `toDot()` method for DOT graph visualization (Graphviz compatible) - Use cycle detection to handle recursive attachment scenarios - Paths are returned in deterministic order (literals sorted, then dynamic) Closes serverpod#319
nielsenko
force-pushed
the
feat-dump-trie
branch
from
1e4279d to
f5840f7
Compare
Collaborator
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds debugging functionality to
PathTriefor diagnosing routing issues:pathsgetter - Returns all registered path patterns asIterable<String>toString()override - Quick text dump of all pathstoDot()method - DOT graph output for Graphviz visualization, with cycles from self-attachment shown as dashed red edgesAll methods handle cycles created by self-attachment.
Related Issues
Pre-Launch Checklist
///), ensuring consistency with existing project documentation.Breaking Changes
Summary by CodeRabbit
New Features
Tests
✏️ Tip: You can customize this high-level summary in your review settings.